Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace black and pylint with ruff #3333

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Replace black and pylint with ruff #3333

merged 1 commit into from
Feb 4, 2025

Conversation

charludo
Copy link
Contributor

@charludo charludo commented Jan 14, 2025 •
edited
Loading

Short description

I am SO sorry, dear reviewers 🙈
@cclauss do you have an opinion on this? 😄

Proposed changes

  • black -> ruff
  • pylint -> ruff

Side effects

  • hahahaha
  • 👀

Resolved issues

Fixes: #3234

Pull Request Review Guidelines

@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 3 times, most recently from 8a99cf6 to 89ef879 Compare January 14, 2025 09:29
@PeterNerlich PeterNerlich self-assigned this Jan 14, 2025
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 2 times, most recently from f914042 to 280f4a6 Compare January 15, 2025 08:59
@charludo charludo marked this pull request as ready for review January 15, 2025 10:57
@charludo
Copy link
Contributor Author

I've marked this as "ready for review". Due to the nature of the PR, this will constantly get merge conflicts, but luckily, 95% of the changes are "automatic" ones from ruff, so please feel free to review even if a merge conflict exists, I'll try to keep up with resolving them.

@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from 280f4a6 to c33177f Compare January 17, 2025 10:38
cclauss
cclauss reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% ruff format

Would reformat: integreat_cms/integreat_celery/celery.py
Would reformat: tests/cms/views/contacts/test_contact_actions.py

.pre-commit-config.yaml Show resolved Hide resolved
.prettierignore Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/src/code-style.rst Outdated Show resolved Hide resolved
docs/src/code-style.rst Show resolved Hide resolved
docs/src/tools.rst Outdated Show resolved Hide resolved
integreat_cms/README.md Outdated Show resolved Hide resolved
@cclauss
Copy link
Contributor

cclauss commented Jan 17, 2025

LGTM!

@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from bc77cd4 to 20bd98f Compare January 17, 2025 17:20
PeterNerlich
PeterNerlich requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@PeterNerlich PeterNerlich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Could it be finally happening??

The only conversation warranting a Request changes is that on integreat_cms/core/apps.py for me, the rest is peanuts

integreat_cms/cms/utils/file_utils.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
integreat_cms/core/apps.py Show resolved Hide resolved
integreat_cms/summ_ai_api/summ_ai_api_client.py Outdated Show resolved Hide resolved
integreat_cms/textlab_api/textlab_api_client.py Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
integreat_cms/api/v3/chat/utils/zammad_api.py Show resolved Hide resolved
integreat_cms/cms/views/dashboard/dashboard_view.py Outdated Show resolved Hide resolved
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 2 times, most recently from 7bd5aa6 to ec87e9e Compare January 22, 2025 12:37
@charludo charludo requested a review from PeterNerlich January 22, 2025 12:37
PeterNerlich
PeterNerlich approved these changes Jan 22, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@JoeyStk JoeyStk added the not-testable Issues that are not testable label Jan 22, 2025
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch 2 times, most recently from 01e0245 to 2ae3881 Compare January 24, 2025 08:18
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from 2ae3881 to d0b6405 Compare January 31, 2025 09:02
cclauss
cclauss reviewed Jan 31, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
MizukiTemma
MizukiTemma approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@MizukiTemma MizukiTemma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😻 🚀
(I played around in the system and it looks everything is still working fine as before)

@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from 7b92121 to 5d4da1f Compare February 4, 2025 13:04
@charludo
Copy link
Contributor Author

charludo commented Feb 4, 2025

@MizukiTemma @PeterNerlich thank you for your reviews. Do you think we should already merge this, or hold off until after a new release has been made? I'm ambivalent.

PeterNerlich
PeterNerlich approved these changes Feb 4, 2025
View reviewed changes
integreat_cms/cms/utils/tree_mutex.py Outdated Show resolved Hide resolved
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from db5d8a8 to 7c003c6 Compare February 4, 2025 16:05
@charludo charludo force-pushed the enhancement/replace-tools-with-ruff branch from 7c003c6 to 16a65da Compare February 4, 2025 16:05
@charludo charludo merged commit 1753a82 into develop Feb 4, 2025
5 checks passed
@charludo charludo deleted the enhancement/replace-tools-with-ruff branch February 4, 2025 16:21
@PeterNerlich PeterNerlich mentioned this pull request Feb 4, 2025
Open
@cclauss
Copy link
Contributor

cclauss commented Feb 4, 2025

Congrats @charludo — Thanks for your perseverance!

@charludo
Copy link
Contributor Author

charludo commented Feb 5, 2025

Congrats @charludo — Thanks for your perseverance!

No, thank YOU - both for pushing ruff as a better alternative to our previous tooling, and for volunteering your time and effort! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss left review comments

@PeterNerlich PeterNerlich PeterNerlich approved these changes

@MizukiTemma MizukiTemma MizukiTemma approved these changes

@JoeyStk JoeyStk Awaiting requested review from JoeyStk

@jonbulz jonbulz Awaiting requested review from jonbulz

@jarlhengstmengel jarlhengstmengel Awaiting requested review from jarlhengstmengel

Assignees

@PeterNerlich PeterNerlich

Labels
not-testable Issues that are not testable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to ruff from pylint & black
5 participants
@charludo @cclauss @PeterNerlich @MizukiTemma @JoeyStk